Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of STM32L432 EEPROM defaults #21981

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Remove duplication of STM32L432 EEPROM defaults #21981

merged 1 commit into from
Sep 12, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 12, 2023 •
edited
Loading

Description

Default vendor driver equates to wear leveling + embedded_flash so specifying it at the keyboard level is redundant.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr closed this Sep 12, 2023
@github-actions github-actions bot added core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support dd Data Driven Changes labels Sep 12, 2023
@zvecr zvecr changed the title Tidy l432 embedded flash Remove duplication of STM32L432 EEPROM defaults Sep 12, 2023
@zvecr zvecr reopened this Sep 12, 2023
@zvecr zvecr changed the base branch from master to develop September 12, 2023 06:33
@github-actions github-actions bot removed core keymap documentation via Adds via keymap and/or updates keyboard for via support dd Data Driven Changes labels Sep 12, 2023
tzarc
tzarc approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA1s are identical.

@zvecr zvecr merged commit 8975dc6 into develop Sep 12, 2023
6 of 9 checks passed
@zvecr zvecr deleted the tidy_l432_embedded_flash branch September 12, 2023 09:09
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@zvecr @mechlovin
Remove duplication of STM32L432 EEPROM defaults (qmk#21981)
84c67a0
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@zvecr @christrotter
Remove duplication of STM32L432 EEPROM defaults (qmk#21981)
8e16133
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@zvecr @zgagnon
Remove duplication of STM32L432 EEPROM defaults (qmk#21981)
61d5254
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@zvecr
Remove duplication of STM32L432 EEPROM defaults (qmk#21981)
1c0dda6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc